included shortcut for Info Panel (issue 2533) #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, I'll review this this week 👍 |
ZeroX-DG
requested changes
Nov 19, 2018
| : e.ctrlKey | ||
| if (isSuper && !e.shiftKey && !e.altKey) { | ||
| e.preventDefault() | ||
| this.addSnippet() |
There was a problem hiding this comment.
What's this addSnippet function 😄
There was a problem hiding this comment.
Ok.
My bad
I thought, since I was at it, I might as well add the shortcuts already implemented for the SnippetNode.
I'll push again with only ctrl+i and ctrl+t
There was a problem hiding this comment.
i mean ctrl+i and ctrl+tab
| : e.ctrlKey | ||
| if (isSuper) { | ||
| e.preventDefault() | ||
| this.focus() |
There was a problem hiding this comment.
The ctrl + l shortcut focuses the search bar, is that the correct behavior?
ZeroX-DG
added
awaiting changes 🖊️
|
Requested changes done. |
ZeroX-DG
added
approved 👍
Rokt33r
added
next release (v0.11.12)
and removed
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think now it will finally be merged